Re: [PATCH] Don't oops when unregistering unknown kprobes

[Prasanna S Panchamukhi]

> @@ -107,6 +107,13 @@ rm_kprobe:
>  void unregister_kprobe(struct kprobe *p)
>  {
>  	unsigned long flags;
> +
> +	if (!get_kprobe(p)) {
> +		printk(KERN_WARNING "Warning: Attempt to unregister "
> +					"unknown kprobe (addr:0x%lx)\n",
> +					(unsigned long) p);
> +		return;
> +	}

This is wrong. You should call get_kprobe() with spin_lock().
 

-Prasanna

-- 

Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<prasanna@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/