Re: [PATCH 1b/7] dlm: core locking

[Domen Puncer]

One thing I noticed (besides some trailing whitespace):

On 26/04/05 00:58 +0800, David Teigland wrote:
> +		if (!r->res_lvbptr)
> +			r->res_lvbptr = allocate_lvb(r->res_ls);
> +
> +		if (!r->res_lvbptr)
> +			return;

This suggests allocate_lvb can fail.

> +
> +		memcpy(r->res_lvbptr, lkb->lkb_lvbptr, DLM_LVB_LEN);

...
However...
> +
> +	if (!r->res_lvbptr)
> +		r->res_lvbptr = allocate_lvb(r->res_ls);
> +
> +	memcpy(r->res_lvbptr, lkb->lkb_lvbptr, DLM_LVB_LEN);

So... can it fail?


	Domen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/