Re: [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers

[Dmitry Torokhov]

On 4/27/05, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> On 4/27/05, Greg KH <gregkh@xxxxxxx> wrote:
> >
> > -stable review patch.  If anyone has any objections, please let us know.
> >
> 
> While the patch is correct I'd have something like this as well:
> 
> --- linux-2.6.11.orig/fs/sysfs/file.c
> +++ linux-2.6.11/fs/sysfs/file.c
> @@ -36,7 +36,7 @@ subsys_attr_store(struct kobject * kobj,
> {
>        struct subsystem * s = to_subsys(kobj);
>        struct subsys_attribute * sattr = to_sattr(attr);
> -       ssize_t ret = 0;
> +       ssize_t ret = -ENOSYS;
> 
>        if (sattr->store)
>                ret = sattr->store(s,page,count);
> 
> So writes without store handler would return "not implemented".
> 

Obviously driver_sysfs_ops, bus_sysfs_ops, etc need the same treatment...

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/