Re: pci-sysfs resource mmap broken (and PATCH)

[Benjamin Herrenschmidt]

On Thu, 2005-04-28 at 09:11 -0600, Grant Grundler wrote:

> 
> > Anyways, what I'm trying to say is that blinding turning prefetchable
> > BAR into "don't set side effect bit in PTE" might not be so wise.
> > 
> > I really think it's a userlevel decision.  That's where all the ioctl()
> > garbage came from for the /proc/bus/pci mmap() stuff.  It was for chossing
> > IO vs MEM space, and also for setting these kinds of mapping attributes.
> 
> Well, if it's a device driver decision, I guess that's ok.
> And the primary device driver happens to live in user space in X.org case.

Agreed, but 1) Do you have an idea on how to expose this capability with
the sysfs interface ? Adding ioctl's to it would suck big time :) and 2)
It's still nice to have a "workaround" for existing X since the
performance benefit is significant, but then, it's in arch code, so
that's fine (and I could indeed limit it to VGA class devices as David
suggests).

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/