Re: 2.6.11.7 kernel panic on boot on AMD64

[Ruben Puettmann]

On Fri, Apr 29, 2005 at 03:10:27AM -0700, Andrew Morton wrote:
> > This is bogus appending stuff to the saved_command_line and at the same
> > time in Rubens case it touches the late_time_init() which breakes havoc.
> 
> -ETOOTERSE.  Do you meen that the user's command line was so long that this
> strcat wandered off the end of the buffer and corrupted late_time_init?
> 
> 
> > Signed-off-by: Alexander Nyberg <alexn@xxxxxxxxx>
> > 
> > Index: linux-2.6/arch/x86_64/kernel/head64.c
> > ===================================================================
> > --- linux-2.6.orig/arch/x86_64/kernel/head64.c	2005-04-26 11:41:43.000000000 +0200
> > +++ linux-2.6/arch/x86_64/kernel/head64.c	2005-04-29 11:57:46.000000000 +0200
> > @@ -93,9 +93,6 @@
> >  #ifdef CONFIG_SMP
> >  	cpu_set(0, cpu_online_map);
> >  #endif
> > -	/* default console: */
> > -	if (!strstr(saved_command_line, "console="))
> > -		strcat(saved_command_line, " console=tty0"); 
> 
> Wasn't that code there for a reason?
> 

The patch didn't apply on 2.6.11.7 it gives this reject file:


***************                                                                                                                    
*** 93,101 ****                                                                                                                    
  #ifdef CONFIG_SMP                                                                                                                
         cpu_set(0, cpu_online_map);                                                                                               
  #endif                                                                                                                           
-        /* default console: */                                                                                                    
-        if (!strstr(saved_command_line, "console="))                                                                              
-                strcat(saved_command_line, " console=tty0");                                                                      
         s = strstr(saved_command_line, "earlyprintk=");                                                                           
         if (s != NULL)                                                                                                            
                 setup_early_printk(s);                                                                                            
--- 93,98 ----                                                                                                                     
  #ifdef CONFIG_SMP                                                                                                                
         cpu_set(0, cpu_online_map);                                                                                               
  #endif                                                                                                                           
         s = strstr(saved_command_line, "earlyprintk=");                                                                           
         if (s != NULL)                                                                                                            
                 setup_early_printk(s);                                                                                            
                                                                                                                                   

After apply by hand it works yes this was ist. Can this be fixed in the
next Versions? 


                        Ruben


-- 
Ruben Puettmann
ruben@xxxxxxxxxxxxx
http://www.puettmann.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/