Re: x86-64 dual core mapping

[Siddha, Suresh B]

On Thu, Apr 28, 2005 at 12:49:42PM -0700, YhLu wrote:
> Please refer to my patch about that.
> 
> --- smpboot.o.c 2005-04-28 13:00:03.611550488 -0700
> +++ smpboot.c   2005-04-28 12:59:27.151093320 -0700
> @@ -652,7 +652,7 @@
>                 int i;
>                 if (smp_num_siblings > 1) {
>                         for_each_online_cpu (i) {
> -                               if (cpu_core_id[cpu] == cpu_core_id[i]) {
> +                               if (cpu_to_node[cpu] == cpu_to_node[i]) {
>                                         siblings++;
>                                         cpu_set(i, cpu_sibling_map[cpu]);
>                                 }

This patch is wrong. It will break Intel systems and I think it is also not 
the correct fix for the systems you are trying to fix.

Please don't do this.

thanks,
suresh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/