Re: [PATCH] fs/Kconfig: more consistent configuration of XFS

From: aq
Date: Fri Apr 29 2005 - 21:03:20 EST


On 4/30/05, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> On Thu, Apr 28, 2005 at 06:21:52PM +0900, aq wrote:
> >
> > OK, here is another patch. It is up to Andrew to pick the approriate.
> > But I still prefer the first patch, which provides both consistency in
> > interface and configuration.
>
> We shall do out best to distribute info to places where it belongs.
> A much better approch would be to move all ext2 + ext3 stuff out in
> their respective directories.
> When modifying xfs (or ext2,ext3) no files outside their respective
> directories should in need to be touched - this would just impose
> additional burden doing parrallel development.

OK, I agree.

>
> About your modifications:
>
> Skipping the menu part is OK.
> While you are modifying Kconfig in xfs/ put a
>
> if XFS_FS
> ...
> endif
>
> around all config options expcept the one defining the XFS_FS option.
> This will fix menu identing.

Thanks for pointing this out. But the patch I posted is fair enough.
It just move one menu item around, and change nothing else. Are you
happy with it?

regards,
aq
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/