[PATCH 4/4] resource release cleanup in net/ (take 2)

[Jesper Juhl]

On Sun, 1 May 2005, Jesper Juhl wrote:

> On Sat, 30 Apr 2005, Arnaldo Carvalho de Melo wrote:
> 
> > On 4/30/05, Jesper Juhl <juhl-lkml@xxxxxx> wrote:
> > > Hi David,
> > > 
> > > Since Andrew merged the patch that makes calling crypto_free_tfm() with a
> > > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for
> > > NULL before calling that function, and while I was at it I removed similar
> > > redundant checks before calls to kfree() and vfree() in the same files.
> > > There are also a few tiny whitespace cleanups in there.
> > 
> > Jesper, I'd suggest that you left whitespaces for a separate patch, it
> > is always,
> > IMHO, better to have as small a patch as possible for reviewing.
> > 
> Sure thing. I've split the patches, and I believe that me going through 
> them a second time did them good, there are a few tiny changes over the 
> first version.
> 
> I split the patch in 4 parts (will send as replies to this mail) : 
> 	1) crypto_free_tfm related changes
> 	2) kfree related changes
> 	3) vfree related changes
> 	4) whitespace changes
> The whitespace changes ended up fairly bigger than initially. I expanded 
> the cleanup a bit. It's not a perfect, 100% complete cleanup, but it's IMO 
> a lot better than the originals.
> 

Here are the whitespace changes. Incremental patch on top of patch 3.
This bit got a little big (~80K), so instead of sending it inline I've 
bzip2 compressed it and attached it to the email.

Signed-off-by: Jesper Juhl <juhl-lkml@xxxxxx>
---

 drivers/net/wireless/airo.c                     | 1026 ++++++++++++------------
 drivers/net/wireless/hostap/hostap_crypt_ccmp.c |    4
 drivers/net/wireless/hostap/hostap_crypt_tkip.c |   25
 net/ieee80211/ieee80211_crypt_ccmp.c            |    3
 net/ieee80211/ieee80211_crypt_tkip.c            |   25
 net/ipv4/ah4.c                                  |    4
 net/ipv4/esp4.c                                 |    4
 net/ipv4/ipcomp.c                               |   11
 net/ipv6/addrconf.c                             |   20
 net/ipv6/ah6.c                                  |    1
 net/ipv6/esp6.c                                 |    4
 net/sctp/socket.c                               |    6
 12 files changed, 589 insertions(+), 544 deletions(-)

Attachment: net-resource-freeing-cleanup-4-whitespace.patch.bz2
Description: net-resource-freeing-cleanup-4-whitespace.patch.bz2