Re: [PATCH] PCI: MSI functionality broken on Serverworks GC chipset

From: David S. Miller
Date: Thu Jun 09 2005 - 17:34:14 EST


From: Greg KH <gregkh@xxxxxxx>
Date: Thu, 9 Jun 2005 15:21:33 -0700

> [PATCH] PCI: MSI functionality broken on Serverworks GC chipset
>
> MSI functionality is broken on the GC_LE x86 chipset that Serverworks
> developed and that is being used in various platforms today. Broadcom is
> going to push out to the kernel MSI enabled Gigabit drivers (in the very
> near future), and we would like to make sure that MSI does not get
> enabled on any platforms using the GC_LE chipset (device id 0x17).
> Following the AMD 8131 example, I am including a patch to disable MSI
> functionality when a GCNB_LE is detected. Please let me know if there
> are any issues with this. This is a permanent fix for this chipset, as
> the hardware will not be updated.
>
> Signed-off-by: Narendra Sankar <nsankar@xxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

"Broadcom's driver" already has MSI support and has a self-test that
checks if MSI operates correctly, and will back out of using MSI if
the MSI test does not pass.

So this patch is not needed for proper functioning of that driver.

This changelog description is very misleading, at best.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/