Re: [PATCH 03/10] IOCHK interface for I/O error handling/detecting

[Hidetoshi Seto]

Matthew Wilcox wrote:
> On Thu, Jun 09, 2005 at 09:51:57PM +0900, Hidetoshi Seto wrote:
>
> > +	switch (dev->hdr_type) {
> > +	case PCI_HEADER_TYPE_NORMAL: /* 0 */
> > +		pci_read_config_word(dev, PCI_STATUS, &status);
> > +		break;
> > +	case PCI_HEADER_TYPE_BRIDGE: /* 1 */
> > +		pci_read_config_word(dev, PCI_SEC_STATUS, &status);
> > +		break;
> > +	case PCI_HEADER_TYPE_CARDBUS: /* 2 */
> > +	default:
> > +		BUG();
>
> If somebody plugs a cardbus card into an ia64 machine, we BUG()?
> Unacceptable.  Just return 0 if you don't know what to do with a
> particular device.

Sure, you are right. I'll fix it.

Thanks,
H.Seto

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/