Re: udp.c

[Måns Rullgård]

Rommer <rommer@xxxxxxxxx> writes:

> Bernd Petrovitsch wrote:
>> On Mon, 2005-06-13 at 14:24 +0200, Måns Rullgård wrote:
>>
>>>Bernd Petrovitsch <bernd@xxxxxxxxx> writes:
>>>
>>>
>>>>On Mon, 2005-06-13 at 14:57 +0300, Rommer wrote:
>>>>
>>>>>Where used strange function udp_v4_hash?
>>>>>linux-2.6.11.11, net/ipv4/udp.c:204
>>>>>
>>>>>static void udp_v4_hash(struct sock *sk)
>>>>
>>>>Since it is "static" the user must be in the same source file (or -
>>>>theoretically - any included header).
>>>
>>>It's not that simple.  It is assigned to the 'hash' field of a struct
>> If you interpret "called" word-by-word yes. I assumed "used".
>>
>>>proto, which is exported.  It could be used from anywhere, but
>> The the OP has to grep for dereferences for this hash variable and
>> check
>> if it is (or may be) from the given struct.
>> Well, that's the virtue of object-orientation: Follow the objects, not
>> the functions/methods.
>>
>>>hopefully isn't.  Something else is supposed to ensure that it is
>>>never called when using the UDP protocol.
>
> So, why BUG(), not just void function?

Calling the function would be the result of a bug elsewhere in the
code, which should be detected and reported.

-- 
Måns Rullgård
mru@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/