Re: [PATCH] 4 of 5 IMA: module measurement patch

From: Chris Wright
Date: Wed Jun 15 2005 - 17:20:58 EST


* Greg KH (greg@xxxxxxxxx) wrote:
> On Wed, Jun 15, 2005 at 10:57:23AM -0400, Reiner Sailer wrote:
> > +extern int ima_terminating;
> > +extern void measure_kernel_module(void *start, unsigned long len, const char __user *uargs);
>
> These belong in a .h file somewhere.

Well, I think they _are_ in a .h file (two of them, in fact), it's the
extern keyword that can be and dup declaration that can be dropped.
However, does this thing even compile w/ CONFIG_IMA_MEASURE=n?
Looks quite broken w.r.t. CONFIG_IMA_MEASURE to me.

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/