Re: [PATCH] Jazzsonic driver updates

[Finn Thain]

On Thu, 16 Jun 2005, Ralf Baechle wrote:

> On Thu, Jun 16, 2005 at 03:45:54AM +1000, Finn Thain wrote:
> 
> > > ... the chip then decides where in that area the recieved packet gets 
> > > buffered ... and that is why I was asking for an alternative to 
> > > vdma_log2phys...
> > 
> > But I forgot that it is possible to have the sonic chip store no more than 
> > one packet in each buffer before moving to the next one in the ring 
> > (though this isn't the case at present). So, as you say, vdma_log2phys 
> > isn't really required.
> 
> Using that option doesn't really seem a good idea anyway.

Sorry, I mislead you (it has been 4 months since I looked at this). The 
existing code does only permit one packet per buffer. I did the same in my 
zero-copy version. So vdma_log2phys really isn't needed, and my patch 
actually removed it along with the memcpy. 

-f

> 
>   Ralf
> -
> To unsubscribe from this list: send the line "unsubscribe linux-mips" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/