Re: [PATCH] pci: don't override drv->shutdown unconditionally

From: Greg KH
Date: Fri Jun 17 2005 - 14:39:38 EST


On Fri, Jun 17, 2005 at 12:01:33PM -0700, Greg KH wrote:
> On Fri, Jun 17, 2005 at 11:53:11AM -0700, Greg KH wrote:
> > On Fri, Jun 17, 2005 at 08:51:04PM +0200, Christoph Hellwig wrote:
> > > They _do_ want it called. They set the driver-model level one because
> > > there hasn't been a pci-level one until a few years ago.
> >
> > So they are setting two callbacks? Have a pointer to any driver that
> > does this?
>
> Ok, I see the drivers that do this now, they should be fixed. I'll make
> up a patch now to do that.

Hm, that's too big of a patch for 2.6.12 this late in the game, I've
forwarded your patch on to Linus with an added comment. I'll fix up the
drivers for 2.6.13 and then change the pci core back.

Sorry for the confusion, you were right.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/