Re: 2.6.12-mm1

From: Andy Whitcroft
Date: Mon Jun 20 2005 - 08:20:46 EST


Having trouble getting 2.6.12-mm1 to compile on my x86 test
boxes other than a basic PC. I suspect this patch is to 'blame'.

> +gregkh-pci-pci-assign-unassigned-resources.patch

We seem to need to include setup-bus.o for most x86 architectures
regardless of HOTPLUG. Not sure if this is the right fix, but it
seems to work on the systems I have tested.

-apw

=== 8< ===
It seems that X86 architectures in general need the setup-bus.o
not just those with HOTPLUG. This avoids the following error on
X86_NUMAQ and x86_64:

arch/i386/pci/built-in.o(.init.text+0x15a6): In function `pcibios_init':
: undefined reference to `pci_assign_unassigned_resources'

Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxx>
---
Makefile | 1 +
1 files changed, 1 insertion(+)
diff -upN reference/drivers/pci/Makefile current/drivers/pci/Makefile
--- reference/drivers/pci/Makefile
+++ current/drivers/pci/Makefile
@@ -19,6 +19,7 @@ obj-$(CONFIG_HOTPLUG_PCI) += hotplug/
#
# Some architectures use the generic PCI setup functions
#
+obj-$(CONFIG_X86) += setup-bus.o
obj-$(CONFIG_ALPHA) += setup-bus.o setup-irq.o
obj-$(CONFIG_ARM) += setup-bus.o setup-irq.o
obj-$(CONFIG_PARISC) += setup-bus.o
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/