Re: [patch 04/12] block/xd: replace schedule_timeout() with msleep()

[Nishanth Aravamudan]

On 21.06.2005 [14:53:49 +0100], Maciej W. Rozycki wrote:
> On Tue, 21 Jun 2005, Domen Puncer wrote:
> 
> > mdelay - busy loop
> > msleep - schedule
> 
>  Right -- that's my mistake.  But what's the point of the change in the 
> first place anyway?  The original code is correct.

Please refer to the comment in the description:

schedule_timeout(1) is ambiguous in older/unchanged code since 2.4, as
it indicated a 10 millisecond sleep then. Now, in 2.6, it indicates a 1
millisecond sleep (HZ==1000). I am trying to prevent issues like this
coming up in the future (CONFIG_HZ has hit -mm, e.g.) and msleep() is a
good way to do so.

If you are trying to sleep for the shortest amount of time possible (a
tick), though, then the code is fine, I guess. A comment may be useful,
though.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/