Re: [RFC: 2.6 patch] better USB_MON dependencies

[Pete Zaitcev]

On Tue, 21 Jun 2005 16:32:27 +0200, Adrian Bunk <bunk@xxxxxxxxx> wrote:

> The patch below tries to solve this in a better way.

>  config USB_MON
> -	tristate "USB Monitor"
> -	depends on USB
> +	bool "USB Monitor"
> +	depends on USB!=n
>  	default y

This is a good idea and I wanted to do it for a while, only I was unable
to figure how to write the "depends on USB!=n" part. I'm all for it.
Let me give it a test here just to be sure, but I think we're good.

One question though, do we want this:

> -obj-$(CONFIG_USB_MON)		+= mon/
> +ifdef CONFIG_USB_MON
> +  obj-$(CONFIG_USB)		+= mon/
> +endif

Seems superfluous to me, because we kept CONFIG_USB_MON. This place should
probably be left alone.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/