Re: reiser4 plugins
From: Andi Kleen
Date: Tue Jun 21 2005 - 20:37:09 EST
First Hans let me remind you that this discussion is not XFS vs
reiser4. Christoph does a lot of reviewing and your child definitely
is in serious need of that to be mergeable. I'm sure Christoph is able
to review inpartially even when he is involved with other FS.
Jeff Garzik <jgarzik@xxxxxxxxx> writes:
>
> You're basically implementing another VFS layer inside of reiser4,
> which is a big layering violation.
>
> This sort of feature should -not- be done at the low-level filesystem level.
>
> What happens if people decide plugins are a good idea, and they want
> them in ext3? We need massive surgery to extract the guts from
> reiser4.
We already kind of have them, there are toolkits to do stackable FS with
the existing VFS.
However I suspect Hans is unwilling to redo his file system in this
point. While it looks quite unnecessary there might be other
areas which deserve more attention. In general all the code
needs review, even if it is not as controversal as the reinvented VFS.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/