Re: [PATCH 3/4] files: change fd_install assertion

[Artem B. Bityuckiy]

Dipankar Sarma wrote:
> Because that way the compare and branch can be ifdefed out when CONFIG_BUG is
> not set. Not to mention BUG_ON() looks more like an assertion.

Surely, even if BUG() will be nothing, the compiler will optimize that?
Yes, it looks better, but I don't like that there was unlikely() before 
and you removed it. I'ts minor though.

--
Best regards, Artem B. Bityuckiy
Oktet Labs (St. Petersburg), Software Engineer.
+78124286709 (office) +79112449030 (mobile)
E-mail: dedekind@xxxxxxxxxxxx, web: http://www.oktetlabs.ru
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/