Re: [PATCH][TRIVIAL] Allocate kprobe_table at runtime

[Andi Kleen]

Prasanna S Panchamukhi <prasanna@xxxxxxxxxx> writes:

> Jeff,
> 
> On Sun, Jun 26, 2005 at 06:37:29PM +0000, Jeff Sipek wrote:
> > Allocates kprobe_table at runtime.
> > -	/* FIXME allocate the probe table, currently defined statically */
> > +	kprobe_table = kmalloc(sizeof(struct hlist_head)*KPROBE_TABLE_SIZE, GFP_ATOMIC);
> 
> Memory allocation using GFP_KERNEL has more chances of success as compared to
> GFP_ATOMIC. Why can't we use GFP_KERNEL here?

I don't see any sense in the change anyways. Just using BSS 
should be fine.

Jeff, when you submit a patch you should add a small blurb
describing why you think it is a good idea.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/