Re: [git patch] DRM 32/64 ioctl patch..

From: Paul Mackerras
Date: Mon Jun 27 2005 - 05:32:14 EST


Arnd Bergmann writes:

> Are you sure that comment still applies? I can't find any reference
> to set_fs in the drm code and compat_alloc_user_space() based handlers
> do not have the problem.

No, the comment is out of date; I changed the code to use
compat_alloc_user_space().

> (void __user *) arg should really be compat_ptr(arg). In theory,
> this is only necessary on s390, which does not implement drm,
> but we just do it the right way so other people don't copy
> the incorrect code.

Good point.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/