Re: Real-Time Preemption, -RT-2.6.12-final-V0.7.50-24

[Ingo Molnar]

* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> Although turning off apm works, this is a fix to the symptom and not a 
> cure.  Has someone already taken a look at this code? Since 
> apm_bios_call_simple calls local_save_flags and afterwards 
> raw_lock_irq_restore is then called.  Shouldn't that have been 
> raw_local_save_flags?

ah, indeed. I fixed this bug and have uploaded the -50-26 patch. Chuck, 
does this fix the APM problems for you?

> That apm_bios_call_simple_asm also looks pretty scary!  I haven't yet 
> figured out how APM_FUNC_VERSION becomes a normal function.

it's all black magic, so when hacking that code i always close my eyes.  
(that's how the bug got introduced)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/