Re: cfq build breakage

[Jens Axboe]

On Tue, Jun 28 2005, Jens Axboe wrote:
> > > > @@ -1969,7 +1968,7 @@ __cfq_may_queue(struct cfq_data *cfqd, s
> > > >  		 * only allow 1 ELV_MQUEUE_MUST per slice, otherwise we
> > > >  		 * can quickly flood the queue with writes from a single task
> > > >  		 */
> > > > -		if (rw == READ || !cfq_cfqq_must_alloc_slice) {
> > > > +		if (rw == READ || !cfq_cfqq_must_alloc_slice(cfqq)) {
> > > >  			cfq_mark_cfqq_must_alloc_slice(cfqq);
> > > >  			return ELV_MQUEUE_MUST;
> > > >  		}
> > > 
> > > thanks, clearly a typo but inside if 0.
> > 
> > But the other instance was inside `#if 1'.  This fixup will change behaviour.
> 
> Hrmpf strange, I submitted what I built. Must be some silly slip up
> here.

Ok double checked, and the above actually builds with gcc 3.3.5 without
any warnings. I've verified the change here, it is sound and acts as it
should.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/