Re: Tracking down a memory leak

[Andrew Morton]

Marco Colombo <marco@xxxxxx> wrote:
>
> Thanks to everybody who replied to me. Here's more data:
> 
>  sh-2.05b# sort -rn +1 /proc/slabinfo | head -5
>  biovec-1          7502216 7502296     16  226    1 : tunables  120   60    0 : slabdata  33196  33196      0
>  bio               7502216 7502262     96   41    1 : tunables  120   60    0 : slabdata 182982 182982      0

Are you using RAID?




From: Neil Brown <neilb@xxxxxxxxxxxxxxx>

insert a missing bio_put when writing the md superblock.

Without this we have a steady growth in the "bio" slab.

Signed-off-by: Neil Brown <neilb@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/md/md.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN drivers/md/md.c~md-bio-leak-fix drivers/md/md.c
--- 25/drivers/md/md.c~md-bio-leak-fix	2005-06-27 22:29:13.000000000 -0700
+++ 25-akpm/drivers/md/md.c	2005-06-27 22:29:13.000000000 -0700
@@ -338,6 +338,7 @@ static int super_written(struct bio *bio
 
 	if (atomic_dec_and_test(&rdev->mddev->pending_writes))
 		wake_up(&rdev->mddev->sb_wait);
+	bio_put(bio);
 	return 0;
 }
 
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/