Re: sysfs abuse in recent i2o changes

[Markus Lidel]

Hello,

Christoph Hellwig wrote:
> drivers/message/i2o/config-osm.c has a function sysfs_create_fops_file,
> which creates a sysfs file with supplied file_operations.  This is
> pretty much against the sysfs design which only wants simple attributes,
> ascsii or for corner cases binary.

I know, but i hopefully also have a good reason to do so... First, the 
attributes provided through these functions are for accessing the 
firmware... The controller has a little limitation, it could only handle 
64 blocks, but sysfs only have 4k...

Now there are two options:

1) when writing: read a 64k block, merge it with the 4k block and write 
it back, when reading: read a 64k block and only return the needed 4k block.

2) extend the sysfs attribute to allow 64k blocks

IMHO the first is not a very good solution, because for a 64k block it 
has to be written 16 times...

Of course if someone finds a better solution i would be glad to hear 
about it...

Thank you very much.


Best regards,


Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)

Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany

Phone:  +49 82 82/99 51-0
Fax:    +49 82 82/99 51-11

E-Mail: Markus.Lidel@xxxxxxxxxxxxxxxxx
URL:    http://www.shadowconnect.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/