Re: [PATCH 2/3] freevxfs: minor cleanups

[Matthias Urlichs]

Hi, Christoph Hellwig wrote:

> On Wed, Jun 29, 2005 at 12:17:17AM -0700, Andrew Morton wrote:
>> Come to think of it, it could be a problem if the comnpiler was silly and
>> built an entire temporary on the stack and the copied it over.  Hopefull it
>> won't do that.
> 
> that patch is fine except for the second to last patch which should be
> droped.

If you do that, you also need to drop the third-to-last patch ...

Personally, I think struct assignments are fine if the compiler
does them right. As this example shows, at least they avoid the
I-forgot-to-zero-the-struct problem. ;-)

-- 
Matthias Urlichs   |   {M:U} IT Design @ m-u-it.de   |  smurf@xxxxxxxxxxxxxx
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
 - -
First Rule of History:
	History doesn't repeat itself -- historians merely repeat each other.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/