Re: [PATCH 8/13]: PCI Err: Event delivery utility

[Linas Vepstas]

On Wed, Jun 29, 2005 at 11:59:47AM +1000, Benjamin Herrenschmidt was heard to remark:
> On Tue, 2005-06-28 at 18:59 -0500, Linas Vepstas wrote:
> > pci-err-8-pci-err-event.patch
> > 
> > [RFC]
> > 
> > PCI Error distribution utility routine.  This patch defines 
> > a utility routine that hasn't yet been discussed much on 
> 
> Certainly needs to be in a separate .h at least ... Also, you have some
> lifetime issues. You probably want to do a get() on pci_dev when you put
> it in your struct and put() it after the notifier... Oh wait, you are
> doing pci_dev_put() ... but no pci_dev_get() ... The later must be
> missing from peh_send_failure_event().

I'm pretty sure this was balanced, there is a get very early on when the
error is detected.  But I'll review.

> I'd keep that in arch code for now.

OK, I'm moving it there. It did seem both confusing and semi-pointless
after the last round of changes.

--linas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/