Re: [PATCH] xip cleanups

[Christoph Hellwig]

On Tue, Jun 28, 2005 at 02:40:29PM +0200, J?rn Engel wrote:
> I personally prefer the original code.  As a general rule, error
> handling code is indented further than regular good-case code.  That
> makes reading a *lot* faster and the compiler should be smart enough
> to generate identical code.

ok..  the cast removal is also wrong as Arnd pointed out, btw.

> > -		(mapping->host,tmp.b_blocknr*(PAGE_SIZE/512) ,&data);
> > +		(mapping->host,tmp.b_blocknr * (PAGE_SIZE/512), &data);
>                                ^
> You missed one.

feel free to add it :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/