RE: [PATCH] ich6m-pciid-piix.patch

[Gaston, Jason D]

Please do not apply this patch.  The ICH6M SATA DID is all ready being used in the SATA ata_piix.c and ahci.c drivers.  Adding the ICH6M SATA DID to the PATA piix.c driver will conflict.  This patch would add the ICH6M SATA controller DID 0x2653 to the PATA piix.c driver.

Thanks,

Jason Gaston


> Message: 224
> Date: Sat, 02 Jul 2005 12:57:54 +0200
> From: Erik Slagter <erik@xxxxxxxxxxxx>
> Subject: [PATCH] ich6m-pciid-piix.patch
> To: linux-ide@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,    Andrew
>         Morton <akpm@xxxxxxxx>
> Message-ID: <1120301874.4300.35.camel@xxxxxxxxxxxxxxxxxxxxx>
> Content-Type: text/plain; charset="us-ascii"
>
> Hi,
>
> I am not sure someone already did this one, but it doesn't seem to be in
> git nor mm at the moment.
>
> This adds ICH6M to the pci ids of the (standard) piix ide driver. This
> makes it possible to use the standard ide driver for this chipset and
> enable udma.
>
> The other way is to use the libata driver, but this has too many
> drawback for the moment (no hdparm/smart/atapi support, with
> patch/#define it does, but doesn't work for me and crashes). Also pata
> harddisks are assigned incorrectly sda device names.
>
> This look okay to me, having said this, I must admit I don't know ***
> from this source file ;-);-)
>
> Thx.
>
> diff -ur a/drivers/ide/pci/piix.c linux-2.6.12/drivers/ide/pci/piix.c
> --- a/drivers/ide/pci/piix.c    2005-06-17 21:48:29.000000000 +0200
> +++ b/drivers/ide/pci/piix.c    2005-07-02 12:37:43.000000000 +0200
> @@ -133,6 +133,7 @@
>                 case PCI_DEVICE_ID_INTEL_82801EB_11:
>                 case PCI_DEVICE_ID_INTEL_ESB_2:
>                 case PCI_DEVICE_ID_INTEL_ICH6_19:
> +               case PCI_DEVICE_ID_INTEL_ICH6_5:
>                 case PCI_DEVICE_ID_INTEL_ICH7_21:
>                 case PCI_DEVICE_ID_INTEL_ESB2_18:
>                         mode = 3;
> @@ -447,6 +448,7 @@
>                 case PCI_DEVICE_ID_INTEL_82801E_11:
>                 case PCI_DEVICE_ID_INTEL_ESB_2:
>                 case PCI_DEVICE_ID_INTEL_ICH6_19:
> +               case PCI_DEVICE_ID_INTEL_ICH6_5:
>                 case PCI_DEVICE_ID_INTEL_ICH7_21:
>                 case PCI_DEVICE_ID_INTEL_ESB2_18:
>                 {
> @@ -575,6 +577,7 @@
>         /* 21 */ DECLARE_PIIX_DEV("ICH7"),
>         /* 22 */ DECLARE_PIIX_DEV("ICH4"),
>         /* 23 */ DECLARE_PIIX_DEV("ESB2"),
> +       /* 24 */ DECLARE_PIIX_DEV("ICH6M"),
>  };
>
>  /**
> @@ -651,6 +654,7 @@
>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_21, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 21},
>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801DB_1, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 22},
>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_18, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 23},
> +       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH6_5, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 24},
>         { 0, },
>  };
>  MODULE_DEVICE_TABLE(pci, piix_pci_tbl);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/