Re: [patch] compress the stack layout of do_page_fault(), x86

From: Andi Kleen
Date: Sat Jul 09 2005 - 14:21:38 EST


On Sat, Jul 09, 2005 at 07:31:04PM +0200, Arjan van de Ven wrote:
> On Sat, 2005-07-09 at 19:05 +0200, Andi Kleen wrote:
> > Ingo Molnar <mingo@xxxxxxx> writes:
> > >
> > > +static void force_sig_info_fault(int si_signo, int si_code,
> > > + unsigned long address, struct task_struct *tsk)
> >
> > This won't work with a unit-at-a-time compiler which happily
> > inlines everything static with only a single caller. Use noinline
>
> but.... the x86 kernel is -fno-unit-at-a-time.... for stack reasons ;)

The gcc people are making noises of removing that. So eventually
it will need to go.

Also some kernels are compiled with that option removed and it works
just fine.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/