Re: [PATCH] tpm: Support for new chip type

[Vojtech Pavlik]

On Sat, Jul 09, 2005 at 09:19:04PM +0200, Pavel Machek wrote:
 
> Ugh, is it just me or are you abusing enums a bit?
> > +static int __init tpm_inf_probe(struct pci_dev *pci_dev,
> > +				const struct pci_device_id *pci_id)
> > +{
> > +
> > +	int rc = 0;
> > +	u8 ioh;
> > +	u8 iol;
> 
> Put these two on one line? Are you sure probe can't be called during
> runtime for some pci hotplug case?
 
__devinit should be used here, if for nothing else, then for sanity's
sake.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/