Re: [patch 2.6.13-git] 8250 tweaks

[Russell King]

On Tue, Jul 12, 2005 at 06:30:43AM -0700, david-b@xxxxxxxxxxx wrote:
> > > ISTR that having NR_UARTS bigger just produced different messages...
> >
> > Which were?
> 
> Error code 22 instead of 28, as I recall.  And as I said, the
> appearance of any (bogus error) message is a "recent" change.
> Two months ago, there were no messages at all.

We now have multiple 8250 platform devices.  I'm sure folk would
want to know if one of their serial ports fails to register.  Hence
the message.  It's not bogus!

22 is EINVAL, which will occur if uartclk is zero, or if the port was
trying to be registered was already registered (not possible.)

So, you're asking the driver to register a port with zero MMIO, IO and
clock values...  Ok, you're asking the driver to do something that is
invalid.  Sounds like its the platform code which is doing the bogus
things.

I don't see why you can't just pass those that you want and no more.
Either build the table dynamically with just the ports that you want
listed and the rest completely zeroed, or register several platform
devices, one for each port.

You don't need any special hacks in the 8250 driver to "support" this.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/