Re: [PATCH/URL] reiserfs: reformat code with Lindent

From: Linus Torvalds
Date: Tue Jul 12 2005 - 18:13:33 EST




On Tue, 12 Jul 2005, Jeff Mahoney wrote:
>
> This patch contains the result of running scripts/Lindent against
> fs/reiserfs/*.c and include/linux/reiserfs_*.h.

That can't be true. It isn't actually following the Lindent rules. It has
that braindamaged "put the type on a separate line" thing for function
declarations, making a "grep" not show the type. That's very much against
the Linux coding style.

So either your "indent" is broken, or you've used something else than
Lindent.

Also, if it's a pure indentation change with no other changes, I'd almost
prefer it as a script, not a patch. That way it's obvious to everybody
that it's just doing indentation.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/