Re: [patch 2.6.13-git] 8250 tweaks

[Russell King]

On Thu, Jul 14, 2005 at 12:12:02AM -0700, Sam Song wrote:
> It turned out the conflict of uart init definition 
> like MPC10X_UART0_IRQ in ../syslib/mpc10x_common.c 
> and SERIAL_PORT_DFNS in ../platform/sandpoint.h. By
> now, only MPC10X_UART0_IRQ stuff is needed. 
> SERIAL_PORT_DFNS should be omitted. 

Oh dear, it seems that I missed a load of fixups then.  I only
scanned include/asm-* for SERIAL_PORT_DFNS - and I stupidly
thought that PPC this "platform" directory would be in include/asm-ppc.

> Seems it's time for me to stand with Russell:-)

Well, in this case, the "whinging" resulted in finding a _real_ bug
and locating why your ports weren't being found.  So I guess it's
good for something.

Can you mail me a diff of the changes you made to
arch/ppc/platforms/sandpoint.h please?  If that file is being used
it seems that you actually have 4 ports defined in total.  However,
I'm a little confused because the sandpoint.h defines don't seem to
match your original dmesg output.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/