Re: [PATCH 2.6.13-rc2-mm2 5/7] v9fs: 9P protocol implementation (2.0.2)

From: Christoph Hellwig
Date: Thu Jul 14 2005 - 14:59:13 EST


> +static inline void buf_check_size(struct cbuf *buf, int len)
> +{
> + if (buf->p+len > buf->ep) {
> + if (buf->p < buf->ep) {
> + eprintk(KERN_ERR, "buffer overflow\n");
> + buf->p = buf->ep + 1;
> + }
> + }
> +}

"handling" a buffer overflow with a printk doesn't seem appopinquate.
In what cases can this happen and what problems may it cause?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/