Re: 2.6.13-rc3 test: finding compile errors with make randconfig

[Grant Coady]

On Sun, 24 Jul 2005 22:39:32 +0200, Adrian Bunk <bunk@xxxxxxxxx> wrote:

>On Mon, Jul 25, 2005 at 05:42:58AM +1000, Grant Coady wrote:
>> On Sun, 24 Jul 2005 11:13:27 +0200, Adrian Bunk <bunk@xxxxxxxxx> wrote:
>> >
>> >it's generally useful, but the target kernel should be the latest -mm
>> >kernel. 
>> 097-error:drivers/char/drm/drm_memory.h:163: error: redefinition of `drm_ioremap_nocache'
>> 097-error:drivers/char/drm/drm_memory.h:163: error: `drm_ioremap_nocache' previously defined here
>> 097-error:drivers/char/drm/drm_memory.h:174: error: redefinition of `drm_ioremapfree'
>> 097-error:drivers/char/drm/drm_memory.h:174: error: `drm_ioremapfree' previously defined here
>
>This requires the .config for debugging.
Here:
  ftp://ftp.scatter.mine.nu/develop/trial4-097-config.gz

>My first guess is that drm_memory.h requires a simple #ifdef to allow 
>multiple inclusions.

I can tell you:
--- linux-2.6.12.3b/drivers/char/drm/drm_memory.h.orig	2005-06-18 05:48:29.000000000 +1000
+++ linux-2.6.12.3b/drivers/char/drm/drm_memory.h	2005-07-25 06:57:41.000000000 +1000
@@ -33,6 +33,9 @@
  * OTHER DEALINGS IN THE SOFTWARE.
  */
 
+#ifndef DRM_MEMORY_H
+#define DRM_MEMORY_H
+
 #include <linux/config.h>
 #include <linux/highmem.h>
 #include <linux/vmalloc.h>
@@ -194,4 +197,5 @@
 	iounmap(pt);
 }
 
+#endif

does not fix it, though it's probably not what you had in mind, first try...
Simple fix didn't...  Now I got to read the code, takes a little more 
effort :)
...
>You aren't running into problems that are already fixed (see your second 
>example above).
I see your point, thanks for feedback.  

Grant.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/