Re: [patch] Support powering sharp zaurus sl-5500 LCD up and down

[Andrew Morton]

Pavel Machek <pavel@xxxxxx> wrote:
>
> This adds support for powering Zaurus's video up and down.

I assume you have a new toy ;)

>  PDA without
> screen is kind of useless, so it is quite important... I'll have to
> figure out how to really control the frontlight, because LCD without
> that is quite hard to read.

signed-off-by?

> @@ -0,0 +1,156 @@
> +/*
> + * Backlight control code for Sharp Zaurus SL-5500
> + *
> + * Copyright 2005 John Lenz <lenz@xxxxxxxxxxx>
> + * GPL v2

Who is the maintainer for this stuff?

> +static struct locomo_dev *locomolcd_dev = NULL;

bah.

> +void locomolcd_power(int on)
> +{
> +	int comadj = 118;
> +	unsigned long flags;
> +	
> +	local_irq_save(flags);

What strange locking this driver uses.  It appears to be assuming
uniprocessor, yes?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/