Re: [patch] Support powering sharp zaurus sl-5500 LCD up and down

From: Pavel Machek
Date: Wed Jul 27 2005 - 05:10:21 EST


Hi!

> > > > +/*
> > > > + * Backlight control code for Sharp Zaurus SL-5500
> > > > + *
> > > > + * Copyright 2005 John Lenz <lenz@xxxxxxxxxxx>
> > > > + * GPL v2
> > >
> > > Who is the maintainer for this stuff?
> >
> > I guess I'll maintain in.
> >
> > > > +static struct locomo_dev *locomolcd_dev = NULL;
> > >
> > > bah.
> >
> > Well, sa1100fb_lcd_power is not provide us with void * we could use,
> > and by definition you only have one frontlight in a PDA, so that
> > should be okay...
>
> "bah" means "there's no need to initialise this to NULL".

Okay, that's kind of easier to fix ;-). Done here, it will eventually
propagate.
Pavel
--
teflon -- maybe it is a trademark, but it should not be.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/