Re: [PATCH] Fix incorrect Asus k7m irq router detection

[Dave Jones]

On Wed, Jul 27, 2005 at 10:10:35AM -0700, Aleksey Gorelov wrote:
 
 > > >  static __init int via_router_probe(struct irq_router *r, 
 > >struct pci_dev *router, u16 device)
 > > >  {
 > > >  	/* FIXME: We should move some of the quirk fixup stuff here */
 > > > +
 > > > +	if (router->device == PCI_DEVICE_ID_VIA_82C686 &&
 > > > +			device == PCI_DEVICE_ID_VIA_82C586_0) {
 > > > +		/* Asus k7m bios wrongly reports 82C686A as 
 > >586-compatible */
 > > > +		device = PCI_DEVICE_ID_VIA_82C686;
 > > > +	}
 > > > +
 > > >  	switch(device)
 > > >  	{
 > > >  		case PCI_DEVICE_ID_VIA_82C586_0:
 > >
 > >If this really is a problem with that board, it should have a DMI entry
 > >for that board alone, not for every VIA chipset that uses the 
 > >586/686 combo,
 > >as I'm fairly certain there are some that legitimately use 
 > >this combination,
 > >and the patch above will force them all to be reported as 82C686's.
 > 
 >   How can they use it legitimately if 586 & 686 routers are not
 > programming register compatible ? Any board which reports  that 686 is
 > compatible with 586 will have that issue.

Actually now that I've woken up properly, your patch looks ok to me.
For some reason I was thinking we were comparing a north and south
bridge here.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/