Re: [PATCH] New include file for marking old style api files

[Jiri Slaby]

Jiri Slaby napsal(a):

> Hi.
> Do you think, that this would be useful in the kernel tree?
> I have an idea to mark old drivers, which should I or somebody rewrite.
> For example drivers/isdn/hisax/gazel.c.
>
> ------------------------------------------------------------------------
>
> diff --git a/include/linux/oldapi.h b/include/linux/oldapi.h
> new file mode 100644
> --- /dev/null
> +++ b/include/linux/oldapi.h
> @@ -0,0 +1,2 @@
> +#warning This driver uses old style API and needs to be rewritten or removed \
> +	from kernel
>  
Maybe this would be better (license and comments added).

--
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      jirislaby@xxxxxxxxx      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10

diff --git a/include/linux/oldapi.h b/include/linux/oldapi.h
new file mode 100644
--- /dev/null
+++ b/include/linux/oldapi.h
@@ -0,0 +1,13 @@
+/**
+  * Include this file, if you think that the driver is old API styled
+  *
+  * Version:	1.0		28 Jul 2005	Initial version
+  *
+  * Author		Jiri Slaby <xslaby@xxxxxxxxxx>
+  *
+  * This software may be used and distributed according to the terms
+  * of the GNU General Public License, incorporated herein by reference.
+  */
+
+#warning This driver uses old style API and needs to be rewritten or removed \
+	from kernel