Re: [PATCH] x86_64: sync_tsc fix the race (so we can boot)

[Eric W. Biederman]

Andi Kleen <ak@xxxxxxx> writes:

> There are some style problems, but that can be fixed later.
>
> How did you track that nasty it down? 

I had a consistent reproducer.  

I ruled out hangs in the tsc sync code itself,
  by implementing timeouts in all of the loops.

I looked for differences with the ia64 code.

I noticed that sometimes the machine would reboot
and not just hang.

I implemented smp_call_function_single since that was what the ia64
code did.  It worked and all of my pieces of evidence just fell
together.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/