Re: Linux 2.6.13-rc4 (snd-cs46xx)

From: Bill Davidsen
Date: Tue Aug 02 2005 - 11:14:21 EST


Steven Rostedt wrote:
On Fri, 2005-07-29 at 10:29 -0700, Linus Torvalds wrote:

On Fri, 29 Jul 2005, Cal Peake wrote:

Thanks Andrew! Indeed your suspicions are correct. Adding in all the debugging moved the problem around, it now shows itself when probing parport. Upon further investigation reverting the commit below seems to have nixed the problem.

Thanks. Just out of interest, does this patch fix it instead?


Oops, never thought that size would be zero coming in. I originally
had it as a while() instead of a do while but thought that I could speed
it up if the first word succeeded. Sorry for that. I blame it on it
being late when I wrote it and trying several different ways. :-P

You are hardly the first person to implement the "it doesn't work right, but it sure is FAST!" algorithm.

--
-bill davidsen (davidsen@xxxxxxx)
"The secret to procrastination is to put things off until the
last possible moment - but no longer" -me
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/