Re: [PATCH,RFC] quirks for VIA VT8237 southbridge

[Alan Cox]

On Maw, 2005-08-16 at 09:49 -0600, Bjorn Helgaas wrote:
> On Tuesday 16 August 2005 9:26 am, Karsten Wiese wrote:
> > What about the following version?
> > quirk_via_686irq() only works on pci_devs that are part of the 686.
> > Sooner or later there'll be more VIA southbridge types, which will
> > not need quirk_via_irq() like the 8237.
> 
> Do you have VIA spec references to support this?  I had a quick
> look, but couldn't find anything specific about which VIA devices
> need the quirk and which don't.

PCI interrupt line routing is used for all V-Bus devices. Thats all
devices in any way on an internal bus of the north or south bridge. The
quirk is harmless when applied to other devices.

Note the description of the quirk is still wrong


> >  * For these devices, this register is defined to be 4 bits wide.
> >  * Normally this is fine.  However for IO-APIC motherboards, or
> >  * non-x86 architectures (yes Via exists on PPC among other places),
> >  * we must mask the PCI_INTERRUPT_LINE value versus 0xf to get
> >  * interrupts delivered properly.

The interrupt line field is used to indicate the ISA type IRQ or the
APIC pin used for the IRQ delivery. See the data sheet.

The & 0x0F is the old hack used to get the ISA type IRQ line in use from
the IRQ number. 

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/