Re: [PATCH 4/14] i386 / Clean up asm and volatile keywords in desc
From: H. Peter Anvin
Date: Tue Aug 16 2005 - 18:50:50 EST
Andi Kleen wrote:
On Wed, Aug 10, 2005 at 09:53:51PM -0700, zach@xxxxxxxxxx wrote:
Stop using extra underscores on asm and volatiles, that is just silly.
Actually the volatiles might be still useful. Or if you drop them
at least add memory clobbers. I had sometimes bugs on x86-64
with the compiler moving such assembly statements with invisible
side effects around too aggressively and causing weird problems.
Agreed on the underscores, I hate them too :)
Well, put volatiles in *unless* the only effect of an asm statement is
producing the output values.
-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/