Re: [PATCH 1/14] i386 / Make write ldt return error code

[Andi Kleen]

On Tue, Aug 16, 2005 at 05:06:18PM -0700, Chris Wright wrote:
> * Andi Kleen (ak@xxxxxxx) wrote:
> > On Wed, Aug 10, 2005 at 09:52:51PM -0700, zach@xxxxxxxxxx wrote:
> > > Xen requires error returns from the hypercall to update LDT entries,
> > > and this generates completely equivalent code on native.
> > 
> > I don't think that is something we want. Nothing in the callers will check
> > the errors anyways. If Xen has such a requirement it should kill
> > the guest when it is violated, otherwise they will be ignored.
> 
> In this case the callers do propagate the error (unless you mean
> userspace doesn't check return value from syscall, which is same problem
> if copy_from_user failed, for example).  Xen has done some more wrapping

Nothing checks them in user space.

Also how would you handle them anyways? It just doesn't make sense.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/