Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

[Chris Wright]

* Andi Kleen (ak@xxxxxxx) wrote:
> On Tue, Aug 16, 2005 at 05:07:36PM -0700, Chris Wright wrote:
> > * Andi Kleen (ak@xxxxxxx) wrote:
> > > On Wed, Aug 10, 2005 at 09:56:40PM -0700, zach@xxxxxxxxxx wrote:
> > > > Add an accessor function for getting the per-CPU gdt.  Callee must already
> > > > have the CPU.
> > > 
> > > What is the accessor good for? 
> > > 
> > > It looks just like code obfuscation to me.
> > 
> > Xen handles gdt differently (one page per cpu instead of per_cpu data).
> > So this is for handling that access cleanly.
> 
> It would be much cleaner to use a per_cpu pointer then and just allocate
> it differently.

OK, that's easily done, but it will add extra indirection.  This currently
changes nothing for common case.  The cpu_gdt_descr effectively has that
address cached already (just not as per_cpu).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/