Re: [RFC] Cleanup line-wrapping in pgtable.h

[Dave Hansen]

On Wed, 2005-08-17 at 12:45 -0500, Adam Litke wrote:
> The line-wrapping in most of the include/asm/pgtable.h pte test/set
> macros looks horrible in my 80 column terminal.  The following "test the
> waters" patch is how I would like to see them laid out.  I realize that
> the braces don't adhere to CodingStyle but the advantage is (when taking
> wrapping into account) that the code takes up no additional space.  How
> do people feel about making this change?  Any better suggestions?  I
> personally wouldn't like a lone closing brace like normal functions
> because of the extra lines eaten.  I volunteer to patch up the other
> architectures if we reach a consensus.

I'd probably just leave it alone.  Those are things that are virtually
never touched, and are quite unlikely to have any bugs in them.

But, if you do decide to change them, it might also be a nice idea to
consolidate some of the ones that are duplicated across architectures.
They could probably even go into the existing
include/asm-generic/pgtable.h.  Please use full, proper CodingStyle if
you do decide to split them across several lines.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/