Re: [PATCH] mmc: Multi-sector writes

From: Russell King
Date: Thu Aug 18 2005 - 03:25:39 EST


On Thu, Aug 18, 2005 at 09:26:03AM +0200, Pierre Ossman wrote:
> We had this discussion on LKML and Alan Cox' comment on it was that a
> solution like this would be acceptable, where we try and shove
> everything out first and then fall back on sector-by-sector to determine
> where an error occurs. This will only break if the problematic sector
> keeps shifting around, but at that point the card is probably toast
> anyway (if the thing keeps moving how can you bad block it?).

There are two different kinds of error - the ones at the transport
level which we are able to force a result of "no sectors transferred"
for. For all other errors and successful completions, the driver
reports "all sectors tranferred" since the driver level doesn't know
that an error occurred.

This causes us to tell the upper levels that we were successful,
even if we weren't. Hence the problem.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/