Re: [git patches] ide update

[Nish Aravamudan]

On 8/18/05, Linus Torvalds <torvalds@xxxxxxxx> wrote:
> 
> 
> On Thu, 18 Aug 2005, Bartlomiej Zolnierkiewicz wrote:
> >
> > 3 obvious fixes + support for 2 new controllers
> > (just new PCI IDs).
> 
> Btw, things like this:
> 
>         +#define IDEFLOPPY_TICKS_DELAY  HZ/20   /* default delay for ZIP 100 (50ms) */
> 
> are just bugs waiting to happen.

<snip>

Shouldn't this be msecs_to_jiffies(50) to avoid the rounding issues I
mentioned on LKML a bit ago?

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/