Re: Kernel bug: Bad page state: related to generic symlink code andmmap

From: Linus Torvalds
Date: Fri Aug 19 2005 - 20:08:48 EST




On Sat, 20 Aug 2005, Al Viro wrote:
>
> That looks OK except for
> * ncpfs fix is actually missing here

Well, the thing is, with the change to page_follow_link() and
page_put_link(), ncpfs should now work fine - it doesn't need any fixing
any more.

It was makign an assumption that used to be incorrect, but that assumption
became ok with the calling convention change - now the page_follow_link()
and page_put_link() functions work fine even if the page cache might get
invalidated in between the calls.

So with your patch, things should be fine (and external filesystems will
generate warnings on compiles, but should work fine, since the change
maintains the ABI even if the API changed - which is pretty unusual).

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/